Re: [PATCH] ensure file size is logged on synchronous writes

xfs

Re: [PATCH] ensure file size is logged on synchronous writes

To:	Lachlan McIlroy <lachlan@xxxxxxx>
Subject:	Re: [PATCH] ensure file size is logged on synchronous writes
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 10 Sep 2007 16:07:45 +0100
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<46DB7A60.4050203@sgi.com>
References:	<46DB7A60.4050203@sgi.com>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.4.2.3i

On Mon, Sep 03, 2007 at 01:07:12PM +1000, Lachlan McIlroy wrote:
> Synchronous writes currently log inode changes before syncing
> pages to disk.  Since the file size is updated on I/O completion
> we wont be writing out the updated file size and if we crash the
> file will have the wrong size.  This change moves the logging
> after the syncing of the pages to ensure we log the correct file
> size.

Looks good to me.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] ensure file size is logged on synchronous writes, Lachlan McIlroy Re: [PATCH] ensure file size is logged on synchronous writes, Christoph Hellwig <=

Previous by Date:	Re: Attempt to Access Beyond End of Device, Justin Piszcz
Next by Date:	Re: [PATCH] cleanup fid types mess, Christoph Hellwig
Previous by Thread:	[PATCH] ensure file size is logged on synchronous writes, Lachlan McIlroy
Next by Thread:	Re: [PATCH] Implement ioctl to mark AGs as "don't use/use", Ruben Porras
Indexes:	[Date] [Thread] [Top] [All Lists]