xfs
[Top] [All Lists]

Re: [PATCH] kill BMAPI_UNWRITTEN

To: Bhagi rathi <jahnu77@xxxxxxxxx>
Subject: Re: [PATCH] kill BMAPI_UNWRITTEN
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 10 Sep 2007 14:02:07 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <cc7060690709091234r115e793p9cc491104862a5cd@mail.gmail.com>
References: <20070909154103.GB19986@lst.de> <cc7060690709091234r115e793p9cc491104862a5cd@mail.gmail.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, Sep 10, 2007 at 01:04:55AM +0530, Bhagi rathi wrote:
> The reason for eliminating BMAPI_UNWRITTEN is not clear. It is ideal to keep
> all the block map
> interfaces and information to go through xfs_iomap, xfs_bmapi functionality.

Despit it's name xfs_iomap_write_unwritten is not a block map interface.
Just take a look at the code, it does not use the block allocator data
structures at all, and it does not do the central xfs_bmapi call
(it uses xfs_bmapi later on but in very different ways).


<Prev in Thread] Current Thread [Next in Thread>