Re: Need of inode->i_mutex in xfs

To:	"David Chinner" <dgc@xxxxxxx>
Subject:	Re: Need of inode->i_mutex in xfs_write()
From:	"kanishk rastogi" <kanishk.85@xxxxxxxxx>
Date:	Fri, 7 Sep 2007 11:28:27 +0545
Cc:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=um0UxphUdVv6auAIIXi4DuF1hxGed51kK7G7gq354jY=; b=MmYxcUTbKhbKcUaI4Ir5DjpXwnaW4ehdowEdxQ7qDzjdvN7aMjEwhtSWRWUh3WsNr4uxenWtO9asYIaOMHwn+GMMbkCuAdIjfwXEGH9Az73u0TYC7FSBQkH3nT2UQfKJAjGNk8h3bNK7ia6pxdSR1a3uG5aRZHIOqKVol784PK0=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jAqInUC8E0zLQToOgf7uzAtT4NoT7jIDcPaQVD3h8YrZGdmL5fjhWmDGqbUF/FlwGP85Svm0Z8HM0kUnahhdZSXWYyS0MOFUnhpKurda5nRMMQOnZA38yMMr8+bP5RQmaPlnO/wUOt6cVu9RcFxdG5mXCjyKW+0y0RKzbvYi2RU=
In-reply-to:	<20070823225111.GW72985246@sgi.com>
References:	<9ee2fe770708210826n5952e727od0df16a5a7b267f0@mail.gmail.com> <20070823225111.GW72985246@sgi.com>
Sender:	xfs-bounce@xxxxxxxxxxx

On 8/24/07, David Chinner <dgc@xxxxxxx> wrote:
> On Tue, Aug 21, 2007 at 09:11:56PM +0545, kanishk rastogi wrote:
> > I was looking at the xfs_write code path in kernel 2.6.20 .......
> > I saw it acquiring inode->i_mutex .
> > Whats the need ?
> > What are we safegaurding inode for.
>
> See Documentation/filesystems/Locking and other files in that
> directory for what i_mutex is supposed to protect.
>
> XFS is different as it has it's own inodes and inode locks, but
> it still mostly uses i_mutex inteh accepted way.
>

xfs_write comes in file_operations->aio_write()
and the documentation doesnt say anything for it to acquire i_mutex in
that path.

I still fail to understand its usage.

Where i am going wrong.

regards
kanishk






> Cheers,
>
> Dave.
> --
> Dave Chinner
> Principal Engineer
> SGI Australian Software Group
>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: Need of inode->i_mutex in xfs_write(), kanishk rastogi <= Re: Need of inode->i_mutex in xfs_write(), David Chinner

Previous by Date:	TAKE 970180 - Link xfsprogs utils to libpthread when linking to libxfs, Barry Naujok
Next by Date:	Not able to register., kanishk rastogi
Previous by Thread:	TAKE 970180 - Link xfsprogs utils to libpthread when linking to libxfs, Barry Naujok
Next by Thread:	Re: Need of inode->i_mutex in xfs_write(), David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: Need of inode->i_mutex in xfs_write()