xfs
[Top] [All Lists]

Re: [PATCH 5/17] move v_iocount from bhv_vnode to xfs_inode

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 5/17] move v_iocount from bhv_vnode to xfs_inode
From: Josef Sipek <jsipek@xxxxxxxxxxxxxxxxx>
Date: Thu, 23 Aug 2007 15:47:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070823193818.GF8050@xxxxxx>
References: <20070823193818.GF8050@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.16 (2007-07-16)
On Thu, Aug 23, 2007 at 09:38:18PM +0200, Christoph Hellwig wrote:
> struct bhv_vnode is on it's way out, so move the I/O count to the XFS inode.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_aops.c    2007-08-23 
> 14:46:18.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c 2007-08-23 14:51:38.000000000 
> +0200
> @@ -140,9 +140,11 @@ xfs_destroy_ioend(
>               next = bh->b_private;
>               bh->b_end_io(bh, !ioend->io_error);
>       }
> -     if (unlikely(ioend->io_error))
> -             vn_ioerror(ioend->io_vnode, ioend->io_error, __FILE__,__LINE__);
> -     vn_iowake(ioend->io_vnode);
> +     if (unlikely(ioend->io_error)) {
> +             vn_ioerror(XFS_I(ioend->io_inode), ioend->io_error,
> +                             __FILE__,__LINE__);

Should it still be called vn_* if it takes an xfs inode? (And yes, I realize
this is a patch in the middle of the series.)

> +     }
> +     vn_iowake(XFS_I(ioend->io_inode));

ditto.

Josef 'Jeff' Sipek.

-- 
A computer without Microsoft is like chocolate cake without mustard.


<Prev in Thread] Current Thread [Next in Thread>