xfs
[Top] [All Lists]

Re: [PATCH] optimize dmapi event tests w/o dmapi config

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] optimize dmapi event tests w/o dmapi config
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Aug 2007 20:07:32 +0100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46C7DD96.6030001@xxxxxxxxxxx>
References: <46C7DD96.6030001@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
On Sun, Aug 19, 2007 at 01:05:10AM -0500, Eric Sandeen wrote:
> Defining XFS_DM_EVENT* macros to 0 in the absence of 
> CONFIG_XFS_DMAPI allows gcc to optimize away tests that 
> should never be true. Also wrap one hunk of xfs_unmount 
> in #ifdef CONFIG_XFS_DMAPI

Sounds useful, especially as dmapi is not in mainline at all.


<Prev in Thread] Current Thread [Next in Thread>