xfs
[Top] [All Lists]

Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into help

To: Jeff Layton <jlayton@xxxxxxxxxx>
Subject: Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 7 Aug 2007 21:51:49 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, zippel@xxxxxxxxxxxxxx, dhowells@xxxxxxxxxx, linux-cifs-client@xxxxxxxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, joel.becker@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx, mikulas@xxxxxxxxxxxxxxxxxxxxxxxx, wli@xxxxxxxxxxxxxx, jffs-dev@xxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, bfennema@xxxxxxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <200708061354.l76Ds6sq002260@xxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, zippel@xxxxxxxxxxxxxx, dhowells@xxxxxxxxxx, linux-cifs-client@xxxxxxxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, joel.becker@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx, mikulas@xxxxxxxxxxxxxxxxxxxxxxxx, wli@xxxxxxxxxxxxxx, jffs-dev@xxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, bfennema@xxxxxxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <200708061354.l76Ds6sq002260@xxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)

This function badly needs a kerneldoc description.  Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)

We should at least add a generic_ prefix to indicate it's a generic
helper valid for most filesystem (and the kerneldoc comment can explain
the details)


<Prev in Thread] Current Thread [Next in Thread>