xfs
[Top] [All Lists]

Re: About errors in XFS header files and xfsprogs

To: Bogdan <bogdandr@xxxxx>
Subject: Re: About errors in XFS header files and xfsprogs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 30 Aug 2007 17:55:56 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <46D6F066.5000009@op.pl>
References: <46D6F066.5000009@op.pl>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
On Thu, Aug 30, 2007 at 06:29:26PM +0200, Bogdan wrote:
>                                The header files should not only be
> ISO-C-compatible, but even ANSI-C-compatible. This will allow anyone
> to use them.

Sais who?  The GNU C extensions are very useful for programming, and
there is no reason to move to an inferior dialect.

>  Please, make useful public functions available in header files.
> Especially platform_check_ismounted() and platform_check_iswritable()
> and other "platform" functions.
> 
>  Also, anything that is a part of the public interface, should be in
> the "xfs namespace", i.e. start with "xfs_". At least one issue of
> this type is known: the list_head structure, declared in other files
> from other libraries. Things like these are very important to fix,
> because they are making other header files useless.

There is no such thing as a public inteface.  There's a good reason
libxfs is not a shared libary - it's really nothing more but a collection
of useful routines for the xfs utilities.

If you think a proper shared library with a defined interface is a good
thing you're probably right, and people would welcome you to work on one.


<Prev in Thread] Current Thread [Next in Thread>