xfs
[Top] [All Lists]

Re: [PATCH V2] make xfs stats Kconfigurable

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] make xfs stats Kconfigurable
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Aug 2007 20:10:10 +0100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46C87C05.5040905@sandeen.net>
References: <46C750C9.8040604@sandeen.net> <46C87C05.5040905@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
On Sun, Aug 19, 2007 at 12:21:09PM -0500, Eric Sandeen wrote:
> Oops, typo in Makefile (CONFIG_XFS_STAT vs _STATS).
> 
> ----
> 
> 
> xfs stats are already optional based on CONFIG_PROC_FS, and there
> is already a (never-set) macro XFS_STATS_OFF which can turn them
> off.  Making it a configurable option, if I turn them off I can
> get a little stack savings on x86, gcc 4.1:

Why would we want to disable the statistics?

> +     config XFS_STATS

Everywhere else the config statement is not indented, so it probably
shouldn't be here either.


<Prev in Thread] Current Thread [Next in Thread>