xfs
[Top] [All Lists]

TAKE 968837 - fix nasty quota hashtable allocation bug

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 968837 - fix nasty quota hashtable allocation bug
From: dgc@xxxxxxx (David Chinner)
Date: Wed, 8 Aug 2007 18:14:14 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
fix nasty quota hashtable allocation bug

This git mod: 77e4635ae191774526ed695482a151ac986f3806

converted to a "greedy" allocation interface, but for the quota hashtables
it switched from allocating XFS_QM_HASHSIZE (nr of elements) xfs_dqhash_t's 
to  allocating only XFS_QM_HASHSIZE *bytes* - quite a lot smaller!  Then when 
we  converted hsize "back" to nr of elements (the division line) hsize went 
to 0. This was  leading to oopses when running any quota tests on the Fedora 8
test  kernel, but the problem has been there for almost a year.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>


Date:  Wed Aug  8 18:13:50 AEST 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  sandeen@xxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:29354a
fs/xfs/quota/xfs_qm.c - 1.52 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_qm.c.diff?r1=text&tr1=1.52&r2=text&tr2=1.51&f=h
        - correct the quota hash allocation size so we allocate a hash the
          size we mean and not something a lot smaller.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 968837 - fix nasty quota hashtable allocation bug, David Chinner <=