xfs
[Top] [All Lists]

Re: Review: demand reaping of filestreams objects

To: Donald Douwsma <donaldd@xxxxxxx>
Subject: Re: Review: demand reaping of filestreams objects
From: David Chinner <dgc@xxxxxxx>
Date: Mon, 30 Jul 2007 15:06:51 +1000
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46AD6DE9.5090806@xxxxxxx>
References: <20070723021051.GV12413810@xxxxxxx> <46AD6DE9.5090806@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Mon, Jul 30, 2007 at 02:49:45PM +1000, Donald Douwsma wrote:
> David Chinner wrote:
> > Now that the problems with cancel_rearming_delayed_workqueue()
> > deadlocks have been fixed, we can go back to only running
> > the reaping when we have objects to time out. This prevents
> > the reaper from running when there is nothing to do.
> 
> You probably meant to remove the printk's,

*nod*

> @@ -206,8 +206,12 @@ _xfs_mru_cache_list_insert(
> ...
> +             if (!mru->queued) {
> +                     printk("reaper started\n");
> 
> @@ -271,29 +275,27 @@ _xfs_mru_cache_reap(
> +     } else
> +     printk("reaper stopped\n");
> 
> Apart from that it looks good, much simpler.

Ok, thanks.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>