xfs
[Top] [All Lists]

Re: [PATCH 7/7] - remove unused variable from locking macros

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/7] - remove unused variable from locking macros
From: David Chinner <dgc@xxxxxxx>
Date: Mon, 23 Jul 2007 09:37:23 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070720073023.GE29295@xxxxxxxxxxxxx>
References: <46A03631.7060604@xxxxxxxxxxx> <20070720073023.GE29295@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Jul 20, 2007 at 08:30:23AM +0100, Christoph Hellwig wrote:
> On Thu, Jul 19, 2007 at 11:12:33PM -0500, Eric Sandeen wrote:
> > The "s" in these locking macros used to be used like flags
> > in spin_lock_irqsave; but in the xfs codebase today it's 
> > never used.
> > 
> > gcc optimizes it away, but still, why keep it around?
> 
> If we change away from the IRIX compatible signatures we could just
> kill the lock wrappers aswell..

Hmmm - decisions, decisions... ;)

I think killing the wrappers entirely is probably the correct thing
to do. stuff like AIL_LOCK and GRANT_LOCK have long just been a
wrapper around a spinlock with no other purpose except to shout at
you.

If we are going to kill the spl return from the spinlocks, then
lets just churn this once. I'll sit on this one for a bit....

FWIW, Eric, if you do decide to modify the patch to kill all the
wrappers, can you send them as a patch-per-wrapper, just to make
it easy to review?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>