xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 7/7] - remove unused variable from locking macros

from [Christoph Hellwig] [Permanent Link][Original]
To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 7/7] - remove unused variable from locking macros
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 20 Jul 2007 08:30:23 +0100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46A03631.7060604@xxxxxxxxxxx>
References: <46A03631.7060604@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i 
On Thu, Jul 19, 2007 at 11:12:33PM -0500, Eric Sandeen wrote:
> The "s" in these locking macros used to be used like flags
> in spin_lock_irqsave; but in the xfs codebase today it's 
> never used.
> 
> gcc optimizes it away, but still, why keep it around?

If we change away from the IRIX compatible signatures we could just
kill the lock wrappers aswell..
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 4/7] - remove xfs_physmem, Christoph Hellwig
Next by Date:  Re: [PATCH 2/7] - choose single default logbuf count & size, Christoph Hellwig
Previous by Thread:  [PATCH 7/7] - remove unused variable from locking macros, Eric Sandeen
Next by Thread:  Re: [PATCH 7/7] - remove unused variable from locking macros, David Chinner
Indexes:  [Date] [Thread] [Top] [All Lists]