xfs
[Top] [All Lists]

Re: [PATCH] fix constness warning in dmapi

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] fix constness warning in dmapi
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 14 Jul 2007 11:45:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070714160910.GE7768@xxxxxx>
References: <20070714160910.GE7768@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.4 (Macintosh/20070604)
Christoph Hellwig wrote:
> File operations are const now so make sure the dmapi code propagates
> this properly.

ACK.  Surprised that was still there :)

> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6-xfs/fs/dmapi/dmapi_kern.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/dmapi/dmapi_kern.h  2007-07-14 16:08:31.000000000 
> +0200
> +++ linux-2.6-xfs/fs/dmapi/dmapi_kern.h       2007-07-14 16:08:41.000000000 
> +0200
> @@ -79,7 +79,7 @@ struct filesystem_dmapi_operations {
>       int (*get_fsys_vector)(struct super_block *sb, void *addr);
>       int (*fh_to_inode)(struct super_block *sb, struct inode **ip,
>                          dm_fid_t *fid);
> -     struct file_operations * (*get_invis_ops)(struct inode *ip);
> +     const struct file_operations * (*get_invis_ops)(struct inode *ip);
>       int (*inode_to_fh)(struct inode *ip, dm_fid_t *fid,
>                          dm_fsid_t *fsid );
>       void (*get_fsid)(struct super_block *sb, dm_fsid_t *fsid);
> Index: linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/dmapi/xfs_dm_fsops.c    2007-07-14 
> 16:07:47.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:55.000000000 
> +0200
> @@ -49,7 +49,7 @@
>  #include "xfs_dm.h"
>  
>  
> -STATIC struct file_operations *
> +STATIC const struct file_operations *
>  xfs_dm_get_invis_ops(
>       struct inode *ip)
>  {
> 
> 


<Prev in Thread] Current Thread [Next in Thread>