xfs
[Top] [All Lists]

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

To: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7][TAKE5] support new modes in fallocate
From: Andreas Dilger <adilger@xxxxxxxxxxxxx>
Date: Thu, 12 Jul 2007 08:40:55 -0600
Cc: Suparna Bhattacharya <suparna@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, David Chinner <dgc@xxxxxxx>, cmm@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070712082650.GB12817@xxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>, Suparna Bhattacharya <suparna@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, David Chinner <dgc@xxxxxxx>, cmm@xxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20070625214626.GJ5181@xxxxxxxxxxxxxxxxxxxx> <20070626103247.GA19870@xxxxxxxxxxxxxxxxxxxx> <20070630102111.GB23568@xxxxxxxxxxxxx> <20070630165246.GA5159@xxxxxxxxxxxxxxxxxxxx> <20070703100848.GA14936@xxxxxxxxxxxxxxxxxxxx> <20070703103107.GA29763@xxxxxxxxxxxxx> <20070703114650.GB14936@xxxxxxxxxxxxxxxxxxxx> <20070711090312.GA18301@xxxxxxxxxxxxx> <20070712072813.GA31260@xxxxxxxxxx> <20070712082650.GB12817@xxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Jul 12, 2007  13:56 +0530, Amit K. Arora wrote:
> As you suggest, let us just have two modes for the time being:
> 
> #define FALLOC_ALLOCATE                       0x1
> #define FALLOC_ALLOCATE_KEEP_SIZE     0x2
> 
> As the name suggests, when FALLOC_ALLOCATE_KEEP_SIZE mode is passed it
> will result in file size not being changed even if the preallocation is
> beyond EOF.

What does FALLOC_ALLOCATE mean vs. not passing this flag?  I have no
objection to this as long as the code remains with these as "flags"
instead of "modes"...  Essentially just dropping the FALLOC_FL_DEALLOCATE
and FALLOC_FL_DEL_DATA from the interface.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.


<Prev in Thread] Current Thread [Next in Thread>