xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

from [Christoph Hellwig] [Permanent Link][Original]
To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH 4/7][TAKE5] support new modes in fallocate
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Jul 2007 10:05:16 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, suparna@xxxxxxxxxx, cmm@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070701225543.GW31489@xxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, suparna@xxxxxxxxxx, cmm@xxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20070614091458.GH5181@xxxxxxxxxxxxxxxxxxxx> <20070614120413.GD86004887@xxxxxxx> <20070614193347.GN5181@xxxxxxxxxxxxxxxxxxxx> <20070625132810.GA1951@xxxxxxxxxxxxxxxxxxxx> <20070625134500.GE1951@xxxxxxxxxxxxxxxxxxxx> <20070625150320.GA8686@xxxxxxxxxxxxxxxxxxxx> <20070625214626.GJ5181@xxxxxxxxxxxxxxxxxxxx> <20070626103247.GA19870@xxxxxxxxxxxxxxxxxxxx> <20070630102111.GB23568@xxxxxxxxxxxxx> <20070701225543.GW31489@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i 
On Mon, Jul 02, 2007 at 08:55:43AM +1000, David Chinner wrote:
> Given the current behaviour for posix_fallocate() in glibc, I think
> that retaining the same error semantic and punting the cleanup to
> userspace (where the app will fail with ENOSPC anyway) is the only
> sane thing we can do here. Trying to undo this in the kernel leads
> to lots of extra rarely used code in error handling paths...

Agreed, looks like we should stay with the user has to clean up behaviour.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 4/7][TAKE5] support new modes in fallocate, Christoph Hellwig
Next by Date:  Re: [PATCH 4/7][TAKE5] support new modes in fallocate, Christoph Hellwig
Previous by Thread:  Re: [PATCH 4/7][TAKE5] support new modes in fallocate, Amit K. Arora
Next by Thread:  Re: xfs_fsr, performance related tweaks, David Chinner
Indexes:  [Date] [Thread] [Top] [All Lists]