xfs
[Top] [All Lists]

Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

To: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Wed, 11 Jul 2007 12:10:34 +1000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070710202000.GB8797@xxxxxxxxxxxxxxxxxxxx>
References: <20070710201200.GA10255@xxxxxxxxxxxxxxxxxxxx> <20070710202000.GB8797@xxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx> 
wrote:
>
> --- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c
> +++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c
> @@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64(int fd, 
>       return sys_fadvise64_64(fd, ((u64)offset_hi << 32) | offset_lo,
>                               len, advice);
>  }
> +
> +asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_lo,
> +                             unsigned offset_hi, unsigned len_lo,
> +                             unsigned len_hi)

Please call this compat_sys_fallocate in line with the powerpc version -
it gives us a hint that maybe we should think about how to consolidate
them.  I know other stuff in that file is called sys32_ ... but it is time
for a change :-)

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgphe7K6M1IiO.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>