Re: REVIEW: Make sure xfs_repair uses sector aligned I/O

[David Chinner <dgc@xxxxxxx>]

On Fri, Jul 13, 2007 at 10:41:47AM +1000, Barry Naujok wrote:
> Two places it didn't:
>  - reading the initial primary superblock
>  - checking the log
> 
> The log checking fix was basically porting the kernel
> xlog_bread/xlog_get_bp/xlog_align from the kernel and
> setting up the log_t structure properly in Phase 2.
> 
> The initial primary superblock read is now done
> using the maximum supported sector size as once the
> block is read and translated to another location,
> it's discarded.

Seems OK from a quick look of the code. Were you able to
confirm that these are the only places we do non-sector sized
I/O?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group