xfs
[Top] [All Lists]

Re: [PATCH 1/7] manpage for fallocate

To: Heikki Orsila <shdl@xxxxxxxxxx>
Subject: Re: [PATCH 1/7] manpage for fallocate
From: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>
Date: Wed, 11 Jul 2007 14:42:24 +0530
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070710213701.GG3400@zakalwe.fi>
References: <20070710201200.GA10255@amitarora.in.ibm.com> <20070710201820.GA8797@amitarora.in.ibm.com> <20070710213701.GG3400@zakalwe.fi>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Wed, Jul 11, 2007 at 12:37:01AM +0300, Heikki Orsila wrote:
> On Wed, Jul 11, 2007 at 01:48:20AM +0530, Amit K. Arora wrote:
> > .BI "int syscall(int, int fd, int mode, loff_t offset, loff_t len);
> 
> Correction: "int syscall(int fd, int mode, ...)",

Here, we have syscall() with first argument being the system call number
- so what you suggested is not correct.

But, yes, the synopsis should change at some time. Maybe to something
like:

        #include <fcntl.h>

        long fallocate(int fd, int mode, loff_t offset, loff_t len);

> > .TP
> > .B ENOSPC
> > There is not enough space left on the device containing the file
> > referred to by
> > .IR fd.
> > .TP
> > .B ESPIPE
> > .I fd
> > refers to a pipe of file descriptor.
> > .B ENOSYS
> > The filesystem underlying the file descriptor does not support this
> > operation.
> 
> EINTR?

Will add following errors:

  EINTR         A signal was caught during execution
  EIO           An I/O error occurred while reading from or writing to
                a file system.
  EOPNOTSUPP    The mode is not supported on the file descriptor.

and will update following :

  EINVAL        offset was less than 0, or len was less than or equal to 0.

--
Regards,
Amit Arora


<Prev in Thread] Current Thread [Next in Thread>