| To: | Barry Naujok <bnaujok@xxxxxxx> |
|---|---|
| Subject: | Re: REVIEW: fix xfs_bmap -vp confusion |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Wed, 11 Jul 2007 15:53:47 +1000 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx> |
| In-reply-to: | <op.tu954us03jf8g2@pc-bnaujok.melbourne.sgi.com> |
| References: | <op.tu954us03jf8g2@pc-bnaujok.melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Wed, Jul 11, 2007 at 01:18:20PM +1000, Barry Naujok wrote: > If xfs_bmap -vp is run on a file without unwritten extents > and the filesystem does not use sunit/swidth, the FLAGS > column is not shown. This leads to some confusion. > > So, when -vp option is used, it will always print the > FLAGS column. I note that it only prints the legend if a flag is set. I guess this is ok, but maybe it would be more consistent to always print the legend? Or even to make the legend optional (which would make dumping more than one file more compact)? Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc, Heiko Carstens |
|---|---|
| Next by Date: | REVIEW: Improve xfs_io and xfs_quota -c handling, Barry Naujok |
| Previous by Thread: | REVIEW: fix xfs_bmap -vp confusion, Barry Naujok |
| Next by Thread: | Re: REVIEW: fix xfs_bmap -vp confusion, Barry Naujok |
| Indexes: | [Date] [Thread] [Top] [All Lists] |