Re: [PATCH 4/7][TAKE5] support new modes in fallocate

["Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>]

On Sat, Jun 30, 2007 at 12:52:46PM -0400, Andreas Dilger wrote:
> The @mode flags that are currently under consideration are (AFAIK):
> 
> FA_FL_DEALLOC         0x01 /* deallocate unwritten extent (default allocate) 
> */
> FA_FL_KEEP_SIZE       0x02 /* keep size for EOF {pre,de}alloc (default change 
> size) */
> FA_FL_DEL_DATA        0x04 /* delete existing data in alloc range (default 
> keep) */

We now have two sets of flags - 
1) the above three with which I think no one has any issues with, and
2) the ones below, for which we need some discussions before finalizing
on them.

I will prefer fallocate going in mainline with the above three modes, and
rest of the modes can be debated upon and discussed parallely. And, each
new mode/flag can be pushed as a separate patch. This will not hold
fallocate feature indefinitely...

Please confirm if you find this approach ok. Otherwise, please object.
Thanks!

> FA_FL_ERR_FREE        0x08 /* free preallocation on error (default keep 
> prealloc) */
> FA_FL_NO_MTIME        0x10 /* keep same mtime (default change on size, data 
> change) */
> FA_FL_NO_CTIME        0x20 /* keep same ctime (default change on size, data 
> change) */

--
Regards,
Amit Arora