Re: [PATCH] Implement ioctl to mark AGs as "don't use/use"

[David Chinner <dgc@xxxxxxx>]

On Thu, Jun 28, 2007 at 12:25:50PM +0200, Ruben Porras wrote:
> Ok, thank you for the explanation, I think that now I got it right.
> Attached is a new patch.

Only one minor nit:

> @@ -558,6 +559,17 @@
>       ASSERT(args->minlen <= args->maxlen);
>       ASSERT(args->mod < args->prod);
>       ASSERT(args->alignment > 0);
> +
> +     /*
> +      * Return an error if the a.g. should not be allocated.
> +      * This happens normally during a shrink operation.
> +      */
> +     pag = (args->pag);

Kill the () here.

Otherwise, looks good.

OOC, do you have any test code for this? xfs_io would be the tool to
teach this ioctl to....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group