| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: review: xfs_growfs_data_private() not logging agf length change |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Thu, 7 Jun 2007 22:49:14 +1000 |
| Cc: | David Chinner <dgc@xxxxxxx>, Tim Shimmin <tes@xxxxxxx>, xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20070607121853.GA29442@xxxxxxxxxxxxx> |
| References: | <4667ADAF.7000904@xxxxxxx> <20070607073034.GP86004887@xxxxxxx> <20070607121853.GA29442@xxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Thu, Jun 07, 2007 at 01:18:53PM +0100, Christoph Hellwig wrote: > On Thu, Jun 07, 2007 at 05:30:34PM +1000, David Chinner wrote: > > On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote: > > > Looks like we forgot to log the agf_length change here. > > > > > > (cut 'n' pasted patch) > > > > > > --Tim ..... > > > > Yup, looks ok to me. > > Except for the whitespace damage, of course - but that might have been > the cut & pasting. The attached patch had no ws damage. ;) Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: review: xfs_growfs_data_private() not logging agf length change, Christoph Hellwig |
|---|---|
| Next by Date: | Re: XFS internal error xfs_da_do_buf(2) at line 2087 of file fs/xfs/xfs_da_btree.c. Caller 0xc01b00bd, David Chinner |
| Previous by Thread: | Re: review: xfs_growfs_data_private() not logging agf length change, Christoph Hellwig |
| Next by Thread: | Re: XFS internal error xfs_da_do_buf(2) at line 2087 of file fs/xfs/xfs_da_btree.c. Caller 0xc01b00bd, Marco Berizzi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |