Re: review: xfs_growfs_data_private() not logging agf length change

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Jun 07, 2007 at 05:30:34PM +1000, David Chinner wrote:
> On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote:
> > Looks like we forgot to log the agf_length change here.
> > 
> > (cut 'n' pasted patch)
> > 
> > --Tim
> > 
> > ===========================================================================
> > Index: fs/xfs/xfs_fsops.c
> > ===========================================================================
> > 
> > --- a/fs/xfs/xfs_fsops.c    2007-04-17 18:02:46.000000000 +1000
> > +++ b/fs/xfs/xfs_fsops.c    2007-04-17 17:59:44.467987572 +1000
> > @@ -328,6 +328,7 @@ xfs_growfs_data_private(
> >         be32_add(&agf->agf_length, new);
> >         ASSERT(be32_to_cpu(agf->agf_length) ==
> >                be32_to_cpu(agi->agi_length));
> > +        xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
> >         /*
> >          * Free the new space.
> >          */
> 
> Yup, looks ok to me.

Except for the whitespace damage, of course - but that might have been
the cut & pasting.