xfs
[Top] [All Lists]

review: xfs_growfs_data_private() not logging agf length change

To: xfs-dev@xxxxxxx
Subject: review: xfs_growfs_data_private() not logging agf length change
From: Tim Shimmin <tes@xxxxxxx>
Date: Thu, 07 Jun 2007 17:03:11 +1000
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (Windows/20070221)
Looks like we forgot to log the agf_length change here.

(cut 'n' pasted patch)

--Tim

===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================

--- a/fs/xfs/xfs_fsops.c    2007-04-17 18:02:46.000000000 +1000
+++ b/fs/xfs/xfs_fsops.c    2007-04-17 17:59:44.467987572 +1000
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
        be32_add(&agf->agf_length, new);
        ASSERT(be32_to_cpu(agf->agf_length) ==
               be32_to_cpu(agi->agi_length));
+        xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
        /*
         * Free the new space.
         */
--- .pc/agf_length.patch/fs/xfs/xfs_fsops.c     2007-06-07 16:19:27.000000000 
+1000
+++ fs/xfs/xfs_fsops.c  2007-06-07 16:23:41.302363734 +1000
@@ -332,6 +332,7 @@ xfs_growfs_data_private(
                be32_add(&agf->agf_length, new);
                ASSERT(be32_to_cpu(agf->agf_length) ==
                       be32_to_cpu(agi->agi_length));
+               xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
                /*
                 * Free the new space.
                 */
<Prev in Thread] Current Thread [Next in Thread>