Re: [PATCH 1/3] XFS metadump utility

["Barry Naujok" <bnaujok@xxxxxxx>]

On Tue, 05 Jun 2007 00:52:58 +1000, Christoph Hellwig <hch@xxxxxxxxxxxxx>  
wrote:
> On Mon, May 28, 2007 at 03:22:52PM +1000, Barry Naujok wrote:
> > Back in February, I posted a patch to xfs_db to capture metadata from a
> > filesystem into a file
> > http://oss.sgi.com/archives/xfs/2007-02/msg00072.html .
> >
> > I have now updated it with the following changes:
> >  - obfuscates directory names and attribute names
> >  - zeros attribute values
> >  - better support of stdin/stdout for redirection.
> Is this the dpprintf to fprintf changes?  These changes look like they
> really want to be in a separate patch with at least a sentence of an
> explanation.
Nah, the fprintf instead of dbprintf was required so errors don't go to
stdout when using stdout as a target.

The better support is using fread/fwrite instead of read/write to a
handle.

> The newly added files look good to me from a quick glance.