On Mon, Jun 25, 2007 at 09:00:02AM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Mon, Jun 25, 2007 at 12:19:15AM -0500, Eric Sandeen wrote:
> >> Don't think I've sent this one yet... :)
> >
> > Any chance we can keep the name lower-cases despite the simplified
> > prototype?
>
> Yeah, it is a bit of a mishmash this way isn't it. SGI guys, do you
> have a preference? Christoph, how would you do it, vn_trace_enter(vp)
> macro calling __vn_trace_enter() function?
Yeah, keep the lower case names if possible. I can't think of a simpler
way of doing it, and it's not terribly ugly. I'm open to better
solutions, though.....
> > Also it might make sense to merge the previous patch into
> > this one.
>
> *shrug* either way.
Keep 'em separate - that way I don't have to go and review this
first one again ;)
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|