xfs
[Top] [All Lists]

Re: [PATCH] remove hard-coded fnames from tracing functions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] remove hard-coded fnames from tracing functions
From: David Chinner <dgc@xxxxxxx>
Date: Mon, 25 Jun 2007 20:49:14 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <467F4A2F.2060101@sandeen.net>
References: <467F48B9.7060504@sandeen.net> <467F4A2F.2060101@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Sun, Jun 24, 2007 at 11:53:03PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > This has been on my stack a while, still compiles clean but feel free
> > to double-check. :-)
> > 
> >  xfs_alloc.c      |   53 ++--------
> >  xfs_bmap.c       |  266 
> > +++++++++++++++++++++++--------------------------------
> >  xfs_bmap.h       |    6 -
> >  xfs_bmap_btree.c |   88 +++---------------
> >  xfs_inode.c      |    8 -
> >  5 files changed, 149 insertions(+), 272 deletions(-)
> > 
> > ---------------
> > 
> > Remove the hardcoded "fnames" for tracing, and just embed
> > them in tracing macros via __FUNCTION__.  Kills a lot of #ifdefs
> > too.
> 
> Hm... guess I did send this one already, but don't see it in cvs...
> Dave, is it in your stack yet?

<sigh>

It got as far as my incoming directory. I even remember reviewing it,
and then I forgot to import the patch. My bad.

I'll add it now.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>