On Sat, Jun 16, 2007 at 09:38:51PM +0100, Christoph Hellwig wrote:
> Thanks, this version looks a lot better now.
>
> The pip checks in xfs_inode.c are still in, but I'm pretty sure they're
> not nessecary, and even if they were nessecary they'd need a good comment
> explaining why.
Because quota inodes don't have a parent and doing filestreams stuff
on quota inodes causes all sorts on problems.
I forgot to split that patch out like you asked last time. Will
now be patch 2, because without this fix we get extra references on
the quota inodes that never get removed and hence busy inodes
after unmount problems....
> The patch still hooks into xfs_close despite your comment that you
> updated it for the removal of it.
<sigh>
That's because it is moved in the xfs_close removal patch later in
my series. I'll move it.
> I still strongly believe the mru cache should not be inside xfs. It's
> a completely generic library function and should go into lib/ so it's
> available to all of the kernel. That means it'll need some codingstyle
> updates and proper kerneldoc comments, though.
And like I said last time: I don't disagree with you.
However: I'm not going to hold back the filestreams code for this.
Doing janitorial work like this is a complete and utter waste of
my time and it does nothing to improve the code right now. I'll
happily accept patches that move this code to lib/ if someone goes
and does it before I find the cycles to be able to do it.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|