xfs
[Top] [All Lists]

Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode

To: Arnd Bergmann <arnd@xxxxxxxx>
Subject: Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode
From: Michal Marek <mmarek@xxxxxxx>
Date: Thu, 31 May 2007 10:10:59 +0200
Cc: Chris Wedgwood <cw@xxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <200705302348.54259.arnd@xxxxxxxx>
References: <20070530125954.706423971@xxxxxxx> <20070530143043.216024061@xxxxxxx> <20070530170530.GA4197@xxxxxxxxxxxxxxxxxxxxx> <200705302348.54259.arnd@xxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.2) Gecko/20061107 SUSE/1.1.1-0.2 SeaMonkey/1.1.1
Arnd Bergmann wrote:
> On Wednesday 30 May 2007, Chris Wedgwood wrote:
>> On Wed, May 30, 2007 at 02:59:55PM +0200, Michal Marek wrote:
>>
>>> +typedef struct xfs_fsop_geom_v132 {
>> wouldn't xfs_fsop_geom_v1_32
...
>> and xfs_fsop_geom_v1_32_t
>>                     ^
>>
>> read better there?
> 
> Actually, the current convention would be struct compat_xfs_fsop_geom_v1
> and compat_xfs_fsop_geom_v1_t.

I see. I'll change it to struct compat_xfs_*.

Michal


<Prev in Thread] Current Thread [Next in Thread>