xfs
[Top] [All Lists]

Re: [PATCH] fix up xfstests a bit for linux+udf

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] fix up xfstests a bit for linux+udf
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 21 May 2007 08:15:45 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <F928335EB5A7F2983790993C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <464C871B.3090402@xxxxxxxxxxx> <F928335EB5A7F2983790993C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.0 (Macintosh/20070326)
Timothy Shimmin wrote:
Thanks, Eric.

We probably should make all ACL/EA tests load up common.attr
(update ones which aren't already - likely the non-acl tests
as common.attr really has acl stuff at the moment)
and then do the udf/linux test in common.attr.

ok, I can do that. I hit a couple other changes, I'll send them all along when I can.

-Eric

--Tim

--On 17 May 2007 11:47:23 AM -0500 Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:

udf on linux doesn't support acls or attrs, so prevent those tests from running.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Index: xfstests/020
===================================================================
--- xfstests.orig/020
+++ xfstests/020
@@ -65,7 +65,7 @@ _attr_list()
   # real QA test starts here
-_supported_fs xfs udf
+_supported_fs xfs
 _supported_os Linux
  [ -x /usr/bin/attr ] || _notrun "attr is not installed"
Index: xfstests/051
===================================================================
--- xfstests.orig/051
+++ xfstests/051
@@ -56,7 +56,7 @@ _cleanup()
 #
  # real QA test starts here
-_supported_fs xfs udf
+_supported_fs xfs
 _supported_os Linux
  [ -x /usr/bin/chacl ] || _notrun "chacl executable not found"
Index: xfstests/062
===================================================================
--- xfstests.orig/062
+++ xfstests/062
@@ -102,7 +102,7 @@ _create_test_bed()
 }
  # real QA test starts here
-_supported_fs xfs udf nfs
+_supported_fs xfs nfs
 _supported_os Linux
  _require_scratch
Index: xfstests/070
===================================================================
--- xfstests.orig/070
+++ xfstests/070
@@ -33,6 +33,7 @@ _cleanup()
 _supported_fs xfs udf nfs
 _supported_os IRIX Linux
+[ "$FSTYP" == udf -a "$HOSTOS" == Linux ] && _notrun "Linux UDF does not support extended
attributes"
 _setup_testdir
  $FSSTRESS_PROG \
Index: xfstests/105
===================================================================
--- xfstests.orig/105
+++ xfstests/105
@@ -35,6 +35,8 @@ _cleanup()
 _supported_fs xfs udf
 _supported_os IRIX Linux
+[ "$FSTYP" == udf -a "$HOSTOS" == Linux ] && _notrun "Linux UDF does not support ACLS"
+
 # real QA test starts here
  rm -f $seq.full







<Prev in Thread] Current Thread [Next in Thread>