| To: | Chris Wedgwood <cw@xxxxxxxx> |
|---|---|
| Subject: | Re: [xfs-masters] 2.6.22-rc2 built on ppc |
| From: | Timothy Shimmin <tes@xxxxxxx> |
| Date: | Mon, 21 May 2007 15:14:34 +1000 |
| Cc: | riesebie@xxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20070521042542.GA11798@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <20070520111408.GF3253@xxxxxxxxxxxxxxxxxxxxx> <9BA71D7C90D3CBF30ABEF4AF@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20070521042542.GA11798@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
--On 20 May 2007 9:25:42 PM -0700 Chris Wedgwood <cw@xxxxxxxx> wrote: On Mon, May 21, 2007 at 01:25:06PM +1000, Timothy Shimmin wrote:However, we can init it on definition to shut the warning up.Please don't. It's not a bug, doing an unneeded init just to silence gcc (gcc could be smarter in some cases) has the potential to hide real bugs later on. :) Yeah, I was discussing with this with someone earlier today. He suggested that it was better to init it (to say NULLRTBLOCK) because it was more likely to find a problem (if we change/add code later on incorrectly) than if we leave it to be unitialised with a random value. --Tim |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [xfs-masters] 2.6.22-rc2 built on ppc, Chris Wedgwood |
|---|---|
| Next by Date: | Re: [PATCH 0/6][TAKE4] fallocate system call, Mingming Cao |
| Previous by Thread: | Re: [xfs-masters] 2.6.22-rc2 built on ppc, Chris Wedgwood |
| Next by Thread: | PARTIAL TAKE 964983 - vmalloc leak on mount/unmount, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |