[Top] [All Lists]

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink p

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?
From: David Chinner <dgc@xxxxxxx>
Date: Fri, 11 May 2007 09:27:29 +1000
Cc: David Chinner <dgc@xxxxxxx>, Chuck Ebbert <cebbert@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4643A5B2.3060906@xxxxxxxx>
References: <20070509231643.GM85884050@xxxxxxx> <4642598E.3000607@xxxxxxxx> <20070510000119.GO85884050@xxxxxxx> <46426194.3040403@xxxxxxxx> <46439185.5060207@xxxxxxxxxx> <464392B4.3070009@xxxxxxxx> <464393E1.3050705@xxxxxxxxxx> <46439491.9010604@xxxxxxxx> <20070510225834.GF86004887@xxxxxxx> <4643A5B2.3060906@xxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/
On Thu, May 10, 2007 at 04:07:30PM -0700, Jeremy Fitzhardinge wrote:
> David Chinner wrote:
> > Just to confirm this isn't a result of a recent change, can you reproduce
> > this on a 2.6.20 or 2.6.21 kernel? (sorry if you've already done this - 
> > I've juggling
> > some many things at once it's easy to forget little things).
> It is the result of a recent change.  I had seen no problem until around
> 2.6.21-git8-11.  I will try again with a plain 2.6.21 kernel, just to
> confirm.

Ok, this is important to kow becase we merged a mod around that time
that changes the way we handle the updates to the file size i.e. the
fix for the NULL-files-on-crash problem:


and that means the size of the file is not updated to the incore
cached inode until after the data write is complete. The symptoms
being seen would match with a inode-not-being-written-after-last-
data-write-bug in this mod....


Dave Chinner
Principal Engineer
SGI Australian Software Group

<Prev in Thread] Current Thread [Next in Thread>