xfs
[Top] [All Lists]

PARTIAL TAKE 964983 - vmalloc leak on mount/unmount

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: PARTIAL TAKE 964983 - vmalloc leak on mount/unmount
From: dgc@xxxxxxx (David Chinner)
Date: Tue, 22 May 2007 09:39:02 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Fix vmalloc leak on mount/unmount.

When setting the length of the iclogbuf to write out we should just
be changing the desired byte count rather completely reassociating
the buffer memory with the buffer. Reassociating the buffer memory
changes the apparent length of the buffer and hence when we free the
buffer, we don't free all the vmap()d space we originally allocated.

Date:  Tue May 22 09:38:29 AEST 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:28640a
fs/xfs/xfs_log.c - 1.331 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log.c.diff?r1=text&tr1=1.331&r2=text&tr2=1.330&f=h
        - Set the iclogbuf I/O size correctly rather than reassociating the
          memory which can lead to vmalloc leaks.



<Prev in Thread] Current Thread [Next in Thread>