xfs
[Top] [All Lists]

Re: Review: ensure EOF writes into existing extents update filesize

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Review: ensure EOF writes into existing extents update filesize
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Sun, 20 May 2007 16:40:48 -0700
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070520233417.GA85884050@sgi.com>
References: <20070520233417.GA85884050@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
On Mon, May 21, 2007 at 09:34:17AM +1000, David Chinner wrote:

> In that case, we use a read mapping of the extent, and this also
> happens to use the read I/O completion handler instead of the
> write I/O completion handle. Hence the file size was not updated
> on I/O completion.
>
> Comments?

I've had this (well, the first version you sent to Jeremy) for a few
days on a testing machine without any obvious ill effects.

Once people are happy with this it should be checked to see if it
needs to go into -stable.


<Prev in Thread] Current Thread [Next in Thread>