xfs
[Top] [All Lists]

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink p

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?
From: David Chinner <dgc@xxxxxxx>
Date: Fri, 11 May 2007 10:32:57 +1000
Cc: David Chinner <dgc@xxxxxxx>, Chuck Ebbert <cebbert@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4643AF8F.5040705@goop.org>
References: <20070510000119.GO85884050@sgi.com> <46426194.3040403@goop.org> <46439185.5060207@redhat.com> <464392B4.3070009@goop.org> <464393E1.3050705@redhat.com> <46439491.9010604@goop.org> <20070510225834.GF86004887@sgi.com> <4643A5B2.3060906@goop.org> <20070510232729.GH86004887@sgi.com> <4643AF8F.5040705@goop.org>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Thu, May 10, 2007 at 04:49:35PM -0700, Jeremy Fitzhardinge wrote:
> David Chinner wrote:
> > Ok, this is important to kow becase we merged a mod around that time
> > that changes the way we handle the updates to the file size i.e. the
> > fix for the NULL-files-on-crash problem:
> >
> > http://git2.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ba87ea699ebd9dd577bf055ebc4a98200e337542
> >
> > and that means the size of the file is not updated to the incore
> > cached inode until after the data write is complete. The symptoms
> > being seen would match with a inode-not-being-written-after-last-
> > data-write-bug in this mod....
> >   
> 
> Yes, that does look like a good candidate.  Should I try to
> before-and-after this change?

Yes please!

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>