xfs
[Top] [All Lists]

Re: [PATCH 5/5] ext4: write support for preallocated blocks/extents

To: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] ext4: write support for preallocated blocks/extents
From: "Pekka Enberg" <penberg@xxxxxxxxxxxxxx>
Date: Mon, 7 May 2007 15:40:26 +0300
Cc: torvalds@xxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, suparna@xxxxxxxxxx, cmm@xxxxxxxxxx
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=urrBzjEDw6lND4d8kP5iZTiYWtAhrbTo0ORHvRO5Ac0osqutU/p2ps7ovA3enA6g5I7Jm25FfmAzxoA7atZKmc+vZuTtqPfy9vd5MJb3PzeWa9bscWaYVyMm7LqyoXNAnbXxY1thOUP7Bbzn5Tcc1AexjGTILIVaW1ugvFG3vGM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=EMuKhDR2U7hdITRMtxB/Oej5BaFNrGc5hvurNCbd0H9fYPUePT20nmMki3NBZJPq657HruCk61mcjc92u/jpzZQ8RuphVoJtrLKhzBQT/CvM4E+FcNF5nfiW9ei7sZh0QH9smIIL1eDa9egvH4kK/9Z+4XVOjfUOcHV5JVm02qg=
In-reply-to: <20070426181623.GE7209@amitarora.in.ibm.com>
References: <20070321120425.GA27273@amitarora.in.ibm.com> <20070329101010.7a2b8783.akpm@linux-foundation.org> <20070330071417.GI355@devserv.devel.redhat.com> <20070417125514.GA7574@amitarora.in.ibm.com> <20070418130600.GW5967@schatzie.adilger.int> <20070420135146.GA21352@amitarora.in.ibm.com> <20070420145918.GY355@devserv.devel.redhat.com> <20070424121632.GA10136@amitarora.in.ibm.com> <20070426175056.GA25321@amitarora.in.ibm.com> <20070426181623.GE7209@amitarora.in.ibm.com>
Sender: xfs-bounce@xxxxxxxxxxx
On 4/26/07, Amit K. Arora <aarora@xxxxxxxxxxxxxxxxxx> wrote:
 /*
+ * ext4_ext_try_to_merge:
+ * tries to merge the "ex" extent to the next extent in the tree.
+ * It always tries to merge towards right. If you want to merge towards
+ * left, pass "ex - 1" as argument instead of "ex".
+ * Returns 0 if the extents (ex and ex+1) were _not_ merged and returns
+ * 1 if they got merged.
+ */
+int ext4_ext_try_to_merge(struct inode *inode,
+                               struct ext4_ext_path *path,
+                               struct ext4_extent *ex)
+{

Please either use proper kerneldoc format or drop "ext4_ext_try_to_merge" from the comment.


<Prev in Thread] Current Thread [Next in Thread>