| To: | "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, suparna@xxxxxxxxxx, cmm@xxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc |
| From: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
| Date: | Thu, 3 May 2007 21:55:28 -0700 |
| In-reply-to: | <20070503212955.b1b6443c.akpm@linux-foundation.org> |
| References: | <20070321120425.GA27273@amitarora.in.ibm.com> <20070329115126.GB7374@amitarora.in.ibm.com> <20070329101010.7a2b8783.akpm@linux-foundation.org> <20070330071417.GI355@devserv.devel.redhat.com> <20070417125514.GA7574@amitarora.in.ibm.com> <20070418130600.GW5967@schatzie.adilger.int> <20070420135146.GA21352@amitarora.in.ibm.com> <20070420145918.GY355@devserv.devel.redhat.com> <20070424121632.GA10136@amitarora.in.ibm.com> <20070426175056.GA25321@amitarora.in.ibm.com> <20070426180332.GA7209@amitarora.in.ibm.com> <20070503212955.b1b6443c.akpm@linux-foundation.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Thu, 3 May 2007 21:29:55 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > + ret = -EFBIG; > > + if (offset + len > inode->i_sb->s_maxbytes) > > + goto out_fput; > > This code does handle offset+len going negative, but only by accident, I > suspect. But it doesn't handle offset+len wrapping through zero. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 5/5] ext4: write support for preallocated blocks/extents, Andrew Morton |
|---|---|
| Next by Date: | Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc, Paul Mackerras |
| Previous by Thread: | Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc, Andrew Morton |
| Next by Thread: | Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc, Paul Mackerras |
| Indexes: | [Date] [Thread] [Top] [All Lists] |