Re: Review - flush blockdev on close

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Tue, Apr 24, 2007 at 11:42:49AM +1000, David Chinner wrote:
> 
> As suggested by Christoph, we probably should flush the block
> device as we complete the process of unmounting the filesystem.
> Patch attached.

Looks good.

> 
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_buf.c     2007-04-24 
> 09:32:22.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c  2007-04-24 11:12:42.181361346 
> +1000
> @@ -1464,6 +1464,7 @@ xfs_free_buftarg(
>       int                     external)
>  {
>       xfs_flush_buftarg(btp, 1);
> +     xfs_blkdev_issue_flush(btp);
>       if (external)
>               xfs_blkdev_put(btp->bt_bdev);
>       xfs_free_bufhash(btp);