On Thu, Apr 19, 2007 at 05:32:16PM +1000, David Chinner wrote:
>
> Save some stack space in the critical allocator paths
> by allocating the xfs_alloc_arg_t structures (104 bytes
> on 64bit, 88 bytes on 32bit systems) rather than placing
> them on the stack.
>
> There can be more than one of these structures on the stack
> through the critical allocation path (e.g. xfs_bmap_btalloc()
> and xfs_alloc_fix_freelist()) so there are significant
> savings to be had here...
I don't like doing even more dynamic allocations that deep
down in the stack. Can we try another approach and see if
we really need the full structure in all places but could
rather pass down a few arguments or a smaller structure instead?
I've done some work on that in the dir good with quite good results
a while ago (and yes, I need to bring it up to date and send it out)
|