xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair - move realtime extent processing to a separate f

To: Barry Naujok <bnaujok@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair - move realtime extent processing to a separate function
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 13 Apr 2007 08:26:47 +0100
Cc: xfs@xxxxxxxxxxx, "'xfs-dev'" <xfs-dev@xxxxxxx>
In-reply-to: <200704130415.OAA16550@xxxxxxxxxxxxxxxxxxxxxxx>
References: <200704130415.OAA16550@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Fri, Apr 13, 2007 at 02:22:10PM +1000, Barry Naujok wrote:
> While changing the process_bmbt_reclist_int() function, I observed a 
> realtime check inside the block map get/set state loop which is quite
> CPU intensive. Upon further investigation, this loop is not used at
> all for realtime extents and that the two types of extents are pretty
> much processed exclusively.
> 
> So, I simplified the functionality by moving the realtime extent
> processing into it's own function and fixing a bug at the same time
> when it comes to realtime inodes with attributes (it was comparing
> attr extents to the realtime volume bmap instead of the normal bmap).

Nice cleanup, looks good.


<Prev in Thread] Current Thread [Next in Thread>