| To: | Nathan Scott <nscott@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] make growfs check device size limits too |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 26 Apr 2007 08:10:55 +0100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1177569014.6273.367.camel@edge> |
| References: | <1177569014.6273.367.camel@edge> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.2i |
On Thu, Apr 26, 2007 at 04:30:14PM +1000, Nathan Scott wrote: > On the mount path we check for a superblock that describes a filesystem > to large for the running kernel to handle. This catches the case of an > attempt to mount a >16TB filesystem on i386 (where we are limited by the > page->index size, for XFS metadata buffers in xfs_buf.c). > > This patch makes similar checks on the growfs code paths for regular and > realtime growth, else we can end up with filesystem corruption, it would > seem (from #xfs chatter). Untested patch follows; probably better to do > this as a macro, in a header, and call that in each place...? Yeah, the check should probably we in one place only. Given that's it's only used in slow pathes a function would probably do it. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] make growfs check device size limits too, Nathan Scott |
|---|---|
| Next by Date: | Re: 2.6.20.3 - possible recursive locking detected - in XFS, Jesper Juhl |
| Previous by Thread: | [PATCH] make growfs check device size limits too, Nathan Scott |
| Next by Thread: | Re: [PATCH] make growfs check device size limits too, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |