[Top] [All Lists]

Re: review [1 of 3]: lazy superblock counters - core kernel

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: review [1 of 3]: lazy superblock counters - core kernel
From: David Chinner <dgc@xxxxxxx>
Date: Wed, 25 Apr 2007 00:16:24 +1000
Cc: David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070424085147.GA28820@infradead.org>
References: <20070419231459.GX48531920@melbourne.sgi.com> <20070423220010.GA18325@infradead.org> <20070424012808.GD48531920@melbourne.sgi.com> <20070424085147.GA28820@infradead.org>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/
On Tue, Apr 24, 2007 at 09:51:47AM +0100, Christoph Hellwig wrote:
> On Tue, Apr 24, 2007 at 11:28:08AM +1000, David Chinner wrote:
> > > This is really quite nasty.  Should we at least force a cache flush here?
> > 
> > Ok, so the patch I sent out was an older version that had a very similar
> > name to the current patch in my series (xfs-lazy-sb vs xfs_lazy_sb).
> > This code doesn't exist in the version I should have sent out.
> > 
> > The latest version, plus the changes suggested here and with the
> > second patch folded back into it is attached.
> Looks like in the new code we simply ignore log reservation
> failures in xfs_log_sbcount?

AFAICT, the only way we can get that error is a fileystem shutdown,
which means we've got an unclean shutdown and so there's no not much
point in syncing the superblock counters because we'll have to
recover them anyway....

> Otherwise this looks good to me.

Thanks for the reviews, Christoph.


Dave Chinner
Principal Engineer
SGI Australian Software Group

<Prev in Thread] Current Thread [Next in Thread>