| To: | Jakub Jelinek <jakub@xxxxxxxxxx> |
|---|---|
| Subject: | Re: Interface for the new fallocate() system call |
| From: | "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 24 Apr 2007 17:46:33 +0530 |
| Cc: | Andreas Dilger <adilger@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, suparna@xxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070420145918.GY355@devserv.devel.redhat.com> |
| References: | <20070316161704.GE8525@osiris.boeblingen.de.ibm.com> <20070317111036.GC29931@parisc-linux.org> <20070321120425.GA27273@amitarora.in.ibm.com> <20070329115126.GB7374@amitarora.in.ibm.com> <20070329101010.7a2b8783.akpm@linux-foundation.org> <20070330071417.GI355@devserv.devel.redhat.com> <20070417125514.GA7574@amitarora.in.ibm.com> <20070418130600.GW5967@schatzie.adilger.int> <20070420135146.GA21352@amitarora.in.ibm.com> <20070420145918.GY355@devserv.devel.redhat.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Fri, Apr 20, 2007 at 10:59:18AM -0400, Jakub Jelinek wrote: > On Fri, Apr 20, 2007 at 07:21:46PM +0530, Amit K. Arora wrote: > > Ok. > > In this case we may have to consider following things: > > > > 1) Obviously, for this glibc will have to call fallocate() syscall with > > different arguments on s390, than other archs. I think this should be > > doable and should not be an issue with glibc folks (right?). > > glibc can cope with this easily, will just add > sysdeps/unix/sysv/linux/s390/fallocate.c or something similar to override > the generic Linux implementation. > > > 2) we also need to see how strace behaves in this case. With little > > knowledge that I have of strace, I don't think it should depend on > > argument ordering of a system call on different archs (since it uses > > ptrace internally and that should take care of it). But, it will be > > nice if someone can confirm this. > > strace would solve this with #ifdef mess, it already does that in many > places so guess another few lines don't make it significantly worse. I will work on the revised fallocate patchset and will post it soon. Thanks! -- Regards, Amit Arora |
| Previous by Date: | [RFC PATCH 2/3] use xfs_reclaim_all in xfs_syncsub, Christoph Hellwig |
|---|---|
| Next by Date: | Re: review [1 of 3]: lazy superblock counters - core kernel, David Chinner |
| Previous by Thread: | Re: Interface for the new fallocate() system call, Jakub Jelinek |
| Next by Thread: | [PATCH 0/5] fallocate system call, Amit K. Arora |
| Indexes: | [Date] [Thread] [Top] [All Lists] |