xfs
[Top] [All Lists]

Re: [PATCH 1/2] fs: remove duplicated iovec checking code v8

To: Dmitriy Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] fs: remove duplicated iovec checking code v8
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 19 Mar 2007 09:28:28 +0000
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, devel@xxxxxxxxxx
In-reply-to: <87slc18yhe.fsf@xxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dmitriy Monakhov <dmonakhov@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, devel@xxxxxxxxxx
References: <87slc18yhe.fsf@xxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Mon, Mar 19, 2007 at 10:49:01AM +0300, Dmitriy Monakhov wrote:
> 
> Where are several places where the same code used for iovec checks.
> This patch just move this code to separate helper function, and replace
> duplicated code with it. IMHO it is better because these are checks that
> we want for all filesystems/drivers that use vectored I/O.

Please move this into the common code path, so it's checked before
entering the filesystem.  This won't cover the calculating count
until we have an iodesc/uio strcuture to pass it down, so feel free
to add a tiny helper for that temporaily.


<Prev in Thread] Current Thread [Next in Thread>