xfs
[Top] [All Lists]

Re: HAVE_FORMAT32 never enabled in mainline

To: Eric Sandeen <sandeen@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Subject: Re: HAVE_FORMAT32 never enabled in mainline
From: Timothy Shimmin <tes@xxxxxxx>
Date: Mon, 19 Mar 2007 12:05:54 +1100
Cc: tes@xxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <45FC650F.70208@xxxxxxxxxxx>
References: <20070317154028.GA18997@xxxxxx> <45FC650F.70208@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
Hi Eric,

--On 17 March 2007 5:00:47 PM -0500 Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:

Christoph Hellwig wrote:
Looks like the code for dealing with x86/amd64 logs is never actually
enable in mainline because nothing defines HAVE_FORMAT32.

Actually since it's all #ifndef (note the n) everything under the #ifndefs -is- 
enabled (since
it's never defined), so I think it's all functional....

Yep (sorry, just missed your email).

structures under the #ifndefs are used
outside the #ifndefs, so the #ifndefs can probably just be removed...?

Would need to sort out the userspace header sharing situation first as
mentioned in the hch email.

Cheers,
Tim.






<Prev in Thread] Current Thread [Next in Thread>