Re: HAVE_FORMAT32 never enabled in mainline

[Timothy Shimmin <tes@xxxxxxx>]

Hi Christoph,

--On 17 March 2007 4:40:28 PM +0100 Christoph Hellwig <hch@xxxxxx> wrote:

> Looks like the code for dealing with x86/amd64 logs is never actually
> enable in mainline because nothing defines HAVE_FORMAT32.
It is enabled, the HAVE_FORMAT32 is #ifndef around some particular type
definitions. (The code has been tested:)

It is currently used because those header files are shared between
userspace and kernel. And in userspace, there is a case where the 32bit
format definition is already defined in another header file - that
case is for IRIX, whose pack syntax is different with its compiler.
So if this is a concern then I would need to have these defined elsewhere
or break the kernel/userspace link on this file, etc...
Suggestions welcome...

--Tim