xfs
[Top] [All Lists]

Re: [RFC][PATCH] sys_fallocate() system call

To: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
Subject: Re: [RFC][PATCH] sys_fallocate() system call
From: Paul Mackerras <paulus@xxxxxxxxx>
Date: Sat, 17 Mar 2007 20:59:05 +1100
Cc: "Amit K. Arora" <aarora@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, suparna@xxxxxxxxxx, cmm@xxxxxxxxxx, alex@xxxxxxxxxxxxx, suzuki@xxxxxxxxxx
In-reply-to: <20070316161704.GE8525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20070117094658.GA17390@xxxxxxxxxxxxxxxxxxxx> <20070225022326.137b4875.akpm@xxxxxxxxxxxxxxxxxxxx> <20070301183445.GA7911@xxxxxxxxxxxxxxxxxxxx> <20070316143101.GA10152@xxxxxxxxxxxxxxxxxxxx> <20070316161704.GE8525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
Heiko Carstens writes:

> So you either rearrange the parameters or convert the loff_t's to pointers.
> 
> e.g.
> 
> asmlinkage long sys_fallocate(int fd, loff_t offset, loff_t len, int mode)
> 
> would work even on s390 ;)

... but wouldn't work on 32-bit powerpc. :(  We would end up with a
pad argument between fd and offset, giving 7 arguments in all
(counting the loff_t's as 2), but we only support 6.

Paul.


<Prev in Thread] Current Thread [Next in Thread>