xfs
[Top] [All Lists]

Re: [PATCH] get rid of fname[] for tracing functions

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] get rid of fname[] for tracing functions
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 07 Mar 2007 08:34:50 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070307082753.GA5469@xxxxxxxxxxxxx>
References: <45EE2EF3.8090707@xxxxxxxxxxx> <20070307082753.GA5469@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (Macintosh/20070221)
Christoph Hellwig wrote:
the vn tracing could probably get a similar treatment, so that every call to vn_trace_foo wouldn't have to include a function name and a __builtin_return_address, but could be done via macros... it's currently a mishmash of __FUNCTION__ and "function" *shrug* what do you think?

It should probably use __FUNCTION__ and hide use of both __FUNCTION__
and __builtin_return_address behind a macro.


Yep, that's exactly what I meant, I've started a patch to do that too.

-Eric


<Prev in Thread] Current Thread [Next in Thread>