xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair doesn't detect corrupt btree roots in nodes

To: Barry Naujok <bnaujok@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair doesn't detect corrupt btree roots in nodes
From: Shailendra Tripathi <stripathi@xxxxxxxxx>
Date: Fri, 09 Mar 2007 11:29:18 +0530
Cc: xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx
In-reply-to: <200703090358.OAA12270@larry.melbourne.sgi.com>
References: <200703090358.OAA12270@larry.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.9 (X11/20041127)
Looks ok to me.

Can you test if it works by manually corrupting some B+Tree using xfs_db (or in fact, you can write a small program which does so. You can just write a program which reads the location on the disk directly, modify the 512 size sector corresponding to these with some selected fields and write them out.)

Try the code when major B+Trees are corrupted --> AGI /BCNTi/BSIZE tree.

-shailendra

Barry Naujok wrote:
Ping?


-----Original Message-----
From: xfs-bounce@xxxxxxxxxxx [mailto:xfs-bounce@xxxxxxxxxxx] On Behalf Of Barry Naujok
Sent: Thursday, 22 February 2007 12:33 PM
To: xfs@xxxxxxxxxxx
Cc: xfs-dev@xxxxxxx
Subject: [PATCH] xfs_repair doesn't detect corrupt btree roots in nodes


The attached patch detect invalid btree root field (numrecs = 0, levels >
permissable value).


The patch also does some cleanup with the level and numrecs usage for the
process_btinode function.





<Prev in Thread] Current Thread [Next in Thread>