Re: Review: freezing sometimes leaves the log dirty

[Nathan Scott <nscott@xxxxxxxxxx>]

On Fri, 2007-02-02 at 11:46 +0000, Christoph Hellwig wrote:
> On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote:
> > +   /* flush inodes and push all remaining buffers out to disk */
> > +   xfs_quiesce_fs(mp);
> > +
> > +   BUG_ON(atomic_read(&mp->m_active_trans) > 0);
> > +
> 
> xfs_vfsops.c is considered common code, so you should probably use
> ASSERT here, not BUG_ON.

There's also an ASSERT_ALWAYS macro IIRC, if you want the equivalent
functionality of BUG_ON (i.e. always check).

cheers.

-- 
Nathan